Parametrize the Slow Test class with two setups. #600
Conversation
- Plots were saved in this directory and taken up whenever needed.
- It returns a dict with two keys, 'config_dirpath' and 'reference_dirpath'. - config_dirpath is the absolute path to directory holding the config file of a particular setup. - reference_dirpath is absolute_dirpath to directory holding the reference data of corresponding setup. - Both are provided by same fixture for better control in parametrization.
- The githash of particular report is formed as a namespace under the 'reports' namespace. - Each figures will now be having name of setup prefixed in their image name.
- This method returns a list of names of directories in 'tests_slow' dir. - This ensures inclusion of all the setups present in this directory and will not require change in source code.
kdexd
force-pushed
the
parametrize-w7-abn-tom
branch
from
d4f743d to
625b7f9
Compare
| @@ -3,4 +3,6 @@ def get_package_data(): | |||
| _ASTROPY_PACKAGE_NAME_ + '.tests': ['coveragerc', 'data/*.h5', | |||
| 'data/*.dat', 'data/*.npy', | |||
| 'tests_slow/w7/*.yml', | |||
| 'tests_slow/w7/*.dat']} | |||
| 'tests_slow/w7/*.dat', | |||
There was a problem hiding this comment.
Does tests_slow/*/*.dat work?
There was a problem hiding this comment.
Yep, I kept it temporarily, time to cleanup ! ✔️
|
@karandesai-96 @yeganer what is going on with this PR? |
|
are we done? |
|
@wkerzendorf This is one point unchecked in this PR.
As we decided to keep it out of this PR, I am done here except any other comments for changes. |
| @pytest.fixture(scope="session") | ||
| def integration_tests_config(request): | ||
| return request.config.option.integration_tests_config | ||
| def setup_names(): |
There was a problem hiding this comment.
Why is this not a fixture?
There was a problem hiding this comment.
It throws an error, that a function is not iterable. I am still confused about a solution for it.
kdexd
force-pushed
the
parametrize-w7-abn-tom
branch
from
de04feb to
5e04b78
Compare
| @@ -1 +1 @@ | |||
| Subproject commit 244c9dd63d291f02c9cadc483d3a9e7a07c124c3 | |||
| Subproject commit b856c6ed9c5c04f27d998a5ef4fe9d728a14ae82 | |||
There was a problem hiding this comment.
We might now want this in here.
|
If the latest comments are implemented we can merge. |
kdexd
force-pushed
the
parametrize-w7-abn-tom
branch
from
5e04b78 to
035a1fa
Compare
kdexd
force-pushed
the
parametrize-w7-abn-tom
branch
from
035a1fa to
c1f78e1
Compare
|
@wkerzendorf @tardis-sn/tardis-core This PR is ready and can be merged. |
This PR introduces parametrization on the class for running Slow Integration tests. Prior to this PR the class did a test run using only Stratified W7 setup. Here, another setup is introduced alongwith W7 and test class executes using both of them.
Checklist for additions / improvements / cleanups :
config.option.tempdiras no longer required.data_pathfixture to facilitate parametrization.❎ Manipulate ID of test method to be displayed on report to sort the test methods according to setup.
Latest report